search: more consistently report timeout errors instead of "No results" when `timeout:` directive is present

Created by: ijt

This is progress on #3294 .

The fix is in search_results.go, where the call to isContextError(ctx, err) has been replaced with a simpler check ignoring ctx.Err() since it can sometimes happen that the indexed search times out without ctx.Err() becoming non-nil. After this change, code search seems to no longer give the erroneous "No results" message on timeouts, although it is still racy and randomly gives different timeout errors.

This change also includes a helpful hint for a longer timeout directive in the error message.

Test plan: I manually tested it with queries like func timeout:1ms on a sourcegraph instance with a single repo.

Before:

After:

Created by: codecov[bot]

Codecov Report

Merging #3395 into master will decrease coverage by 0.01%. The diff coverage is 80%.

Impacted Files	Coverage Δ
cmd/frontend/graphqlbackend/search_results.go	45.11% <0%> (ø)
cmd/frontend/graphqlbackend/textsearch.go	39.69% <100%> (+1.64%)
web/src/nav/UserNavItem.tsx	20% <0%> (-50.97%)
cmd/frontend/graphqlbackend/default_settings.go	0% <0%> (ø)