search: more consistently report timeout errors instead of "No results" when `timeout:` directive is present

Review changes
Download
Patches
Plain diff

Closed search: more consistently report timeout errors instead of "No results" when `timeout:` directive is present

3294-indexed-search-timeouts into master

Overview 1
Commits 21
Pipelines 0
Changes 3

Closed search: more consistently report timeout errors instead of "No results" when `timeout:` directive is present

Administratorrequested to merge

3294-indexed-search-timeouts into master Apr 12, 2019

Overview 1
Commits 21
Pipelines 0
Changes 3

Created by: ijt

This is progress on #3294 .

This also includes a helpful hint for a longer timeout directive in the error message.

Test plan: Manually tested with queries like func timeout:1ms on a sourcegraph instance with a single repo

Before:

After:

The commits shown on github are screwed up and include things from a previous PR. Sorry about that.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.