search: Zoekt query generation does not depend on pattern info
Created by: rvantonder
Previously we created a Zoekt query from PatternInfo
, which we created from the input query, and which was nested inside TextPatternInfo
. With this PR, Zoekt queries are generated directly from Basic Sourcegraph queries. It's a huge victory (on a scale of 1 to 10, this is eleventy). The only caveat is I took a winding road to converge on the solution and preserve existing behavior. I could unwind things and make clean PRs, but instead my plan is to do a walkthrough of the code with Camden directly.
Test plan
Updated existing tests. Semantics-preserving.