Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!32543

Web [Charts]: Use wildcard `Popover` instead of `floating-ui`

Review changes
Download
Patches
Plain diff

Merged Web [Charts]: Use wildcard `Popover` instead of `floating-ui`

vk/refactor-new-line-chart into main

Overview 0
Commits 5
Pipelines 0
Changes 22

Merged Web [Charts]: Use wildcard `Popover` instead of `floating-ui`

Administratorrequested to merge

vk/refactor-new-line-chart into main Mar 13, 2022

Overview 0
Commits 5
Pipelines 0
Changes 22

Created by: vovakulikov

Context

Prior to this PR, we used the floating-ui tooltip for the chart tooltip component. Since we have our own Popover component as a part of the wildcard package this PR simply replaces the floating-ui with our Popover.

Test plan

Make sure that all demos for the /charts/line-chart look good and don't have any problem with the tooltip

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

3

cla-signed data-viz webapp

3

cla-signed data-viz webapp

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

1

1 Participant

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading