Remove italic style on subtitle on search home
Created by: quinnkeast
On the search home, we have a subtitle that reads "Search your code and 2M+ open source repositories" set in an italic text style.
This hasn't felt right to me and I think about it every time I open Sourcegraph, and I finally figured out why it doesn't feel right: when used in copy, italics convey semantic meaning, as demonstrated in this sentence. As used in this subtitle, they don't convey any semantic meaning, so the italics are used only for visual style/hierarchy.
While this seems like a super small thing (which is why I haven't acted on it earlier), I believe it feeds back into our content guidelines and Wildcard more generally and influences design decisions elsewhere.
My feeling is that we should use italics only when we want to highlight something within a line of copy to provide additional semantic meaning. When we want to create additional levels of visual hierarchy for entire lines of text content, we should use other tools at our disposal, like colour, size, and weight.
After this change is applied:
If we're aligned on this as a design team, then I'll follow up when this PR is merged to also update the content guidelines.
Test plan
See screenshots for visual difference.