Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

S

sourcegraph
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Wiki
- Snippets
- Package registry
- Model registry
- Environments
- Terraform modules
- Incidents
- Value stream analytics
- Model experiments

Snippets Groups Projects

!32145

Search backend: remove newSearchClient from streamHandler

Review changes
Download
Patches
Plain diff

Merged Search backend: remove newSearchClient from streamHandler

cc/rm-new-search-client into main

Overview 0
Commits 1
Pipelines 0
Changes 2

Merged Search backend: remove newSearchClient from streamHandler

Administratorrequested to merge

cc/rm-new-search-client into main Mar 3, 2022

Overview 0
Commits 1
Pipelines 0
Changes 2

Created by: camdencheek

We previously used an overrideable function to build a search client so that it could be overridden tests. However, now that our search client is an interface, we can just override it with a mock directly, which simplifies this a bit.

Test plan

Semantics preserving, covered by existing tests.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Loading

Labels

1

1

Select labels

Manage project labels

Milestone

None

None

None

Time tracking

No estimate or time spent

1

1 Participant

There are no commits yet

Push commits to the source branch or add previously merged commits to review them.

Loading