Skip to content

Wildcard: Fix `FeedbackPrompt.tsx` spacing visual bug

Administrator requested to merge vk/fix-feedback-prompt-spacing-bug into main

Created by: vovakulikov

Background

Prior to this PR the textarea component had an incorrect visual spacing values. However we had an explicit styles for this input in the CSS modules file. It turned out that FlexTextarea component has its own styles margin: 0 that overrides consumer FeedbackPrompt styles. The FlexTextarea was added because by default all labels element have some margin values.

I think the problem here is deeper that it looks like at the first glance. I think that FlexTextarea component shouldn't provide element with label as a part of internal implementation component. This makes API of this component more complicated (like having separate className props for the root element and input element it brings some misunderstanding in popular case of usage) Instead of this I think a composition of Label and FlexTextarea components right in the consumer would have worked better in our cases. @sourcegraph/frontend-platform-devs what do you think?

Test plan

  • Make sure that FeedbackPrompt component has a right spacings between texarea and other form input components.

Merge request reports