search: simplify job mode logic
Created by: rvantonder
Main change: previously, we mutated args
to set args.Mode
after doing some comparisons. This PR removes the mutation/comparison on args.Mode
before creating jobs. Please go by commit.
For context, I'm doing this stuff so I can reuse parts for optimization. Anyway, it all tends to simplify/improve when working through things.
Test plan
Semantics-preserving