Skip to content
Snippets Groups Projects

Notebook: embed route bundle debug

Created by: vovakulikov

Based on https://github.com/sourcegraph/sourcegraph/pull/30669

Experimental PR: Do not merge this one anywhere

Basically this PR just moves all notebook deps from the main route (bundle) to the lazy-loaded notebook route where all those deps were used.

Original PR bundle
This PR bundle size
Screenshot 2022-02-08 at 13 08 07 Screenshot 2022-02-08 at 13 08 15

But still, this embed bundle looks strange. It seems like it has some part from the main App bundle for example - 'react-grid-layout' lib

Screenshot 2022-02-08 at 13 07 36 The screenshot above statoscope shows that the embed bundle has this package included in its bundle. But we know that only Code Insights (which is not in the embed bundle) has this dependency.

My guess is that we use global css styles imports for the react-grid in the SourcegraphWebApp.scss file and this might be a culprit here

It seems like our cache group settings don't work properly if we have more than one bundle entry point (which is the case now when we have embed entry point together with the main app entry point in the webpack config)

Merge request reports

Approval is optional

Closed by avatar (Sep 12, 2025 3:38pm UTC)

Merge details

  • The changes were not merged into main.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading