Skip to content

search: remove duplicate event SearchResultClicked

Administrator requested to merge sh/duplicate-SearchResultsClicked into main

Created by: stefanhengl

For each click on a file match in the list of search results, we currently send out 2 event logs of type "SearchResultClicked" with the only difference being the value of the url field (search page vs. blob page).

image

I don't believe there is a reason to keep both. Let's remove the call to onSelect from FileMatchChildren and keep it for the ResultContainer. This way we can treat the other match types, IE those without children, the same.

This is related to #29909, where the duplicate event leads to a double counting of clicked results.

Merge request reports

Loading