Skip to content

[SG-27728] Wildcard V2: `<Select />` Manual migration

Administrator requested to merge contractors/SG-27728 into main

Created by: gitstart-sourcegraph

Manual migration required to update our code to use the <Select /> Wildcard component.

See Wildcard V2 - Planned work for more context.

Note: Before doing this, we should check if there is scope for a codemod to automate this migration. If so, the codemod should be implemented and ran before starting work on this issue.

Refs

Sourcegraph Issue Gitstart Ticket

Implementation

  1. Find all remaining usage of the <select> element: https://sourcegraph.com/search?q=context:global+repo:github.com/sourcegraph/sourcegraph+%3Cselect&patternType=literal.
  2. Replace with the <Select /> Wilcard component: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@contractors/SG-27660/-/blob/client/wildcard/src/components/Form/Select/Select.tsx?utm_source=VSCode-1.4.0#L60:24

Acceptance criteria.

  • All incorrect usage of the previous pattern has been updated to use the Wildcard component

Test plan

Tested through:

  • Visual tests in the Percy diff and Chromatic diff
  • Pulling the code locally and running the application
  • Unit tests in CI

Merge request reports