Something went wrong while fetching comments. Please try again.
Created by: umpox
Closes https://github.com/sourcegraph/sourcegraph/issues/27697
Implements a simple styled wrapper around our @reach/dialog
Modal implementations. These are used extensively across the webapp so this component will help align our styles and ensure code is not repeated.
Reasoning for renaming Dialog
to Modal
:
Modal
is a more descriptive name for what this actually is. Dialog is how it can be used.Dialog
are actually named as Modal
. See here
Popover
and Modal
rather than Popover
and Dialog
. The latter confused me as Popover
s can appear quite similar to a typical dialogThe code migration will be done as part of https://github.com/sourcegraph/sourcegraph/issues/27698
It should look something like this:
@reach/dialog
imports to Wildcard imports. Update props and remove any unnecessary styles.reactstrap
Modal
imports to Wildcard imports and update as necessarymodal-body
| modal-X
classes to Modal
Wildcard component.