Something went wrong while fetching comments. Please try again.
Created by: mollylogue
Behavior introduced by this PR:
git.NewFileReader
will return nil
. Are we okay with this behavior? If the possibility of a nil reader isn't handled wherever git.NewFileReader
is created, we could end up with an exception (i.e. calling defer reader.Close()
on a nil reader). Alternatively, we could return an error if the user doesn't have access? I don't have enough visibility into how this is being used to know what's best, but based on some spot checking it does look like we check for a reader being nil
or not.