search: preserve scroll position on navigating back to search results

Review changes
Download
Patches
Plain diff

Merged search: preserve scroll position on navigating back to search results

vb/search-scroll-restoration-2 into vb/search-scroll-restoration-1

Overview 2
Commits 2
Pipelines 0
Changes 7

Merged search: preserve scroll position on navigating back to search results 🎉

Administratorrequested to merge

vb/search-scroll-restoration-2 into vb/search-scroll-restoration-1 Dec 17, 2021

Overview 2
Commits 2
Pipelines 0
Changes 7

Created by: valerybugakov

Context

The scroll position is not preserved when going back to search results.

Changes

TLDR The scroll position is now preserved for page refresh and back navigation

This PR does two things:

Adds ScrollManager that tracks the scroll position of the search results container, persists it to session storage, and restores it on back navigation or page refresh.
- react-scroll-manager is used to handle scroll position info.
To avoid multiple UI jumps required to reach the previous scroll position, we need to render all items that the user already scrolled through. It's done by extending the itemsToShow state used in StreamingSearchResultsList.
- It tracks the number of items shown for the last query and persists this info to session storage.
- See use-items-to-show.test.ts with tests for all important use-cases.

https://user-images.githubusercontent.com/3846380/146541677-b48456d9-eaa5-42bd-a550-6fbeb97fc248.mov

Should be merged together with https://github.com/sourcegraph/sourcegraph/pull/29176. Closes https://github.com/sourcegraph/sourcegraph/issues/28845.

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

cla-signed search-ux team/frontend-platform

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.