Skip to content

Error handling and locking

Administrator requested to merge insights/api/oob-errors into insights/api/oob-migration

Created by: CristinaBirkel

Error handling:

  • If it's an unresolvable schema error, skip the item and count it as complete.
  • If it's a transient error, return right away and it will try again next time around.

Downside to this is that we won't return errors for the schema errors. But attempting to do so would (I think,) make the code more complex because we'd need to maintain a separate list of errors so that we know when to return vs. when to continue and return the errors just at the end. I'm not sure it's worth it.

Transactions/Locking:

  • I added a transaction around the SettingsMigrationJobsStore so that we can lock those rows for processing. I'm not sure any of the other db interactions require specific transactions because they should all be synchronous at that point. Each settings object will contain unique data and I don't see any real potential for clashes there, though I could be missing something.

Merge request reports