Skip to content
Snippets Groups Projects

Wildcard: Add first implementation of `<MultiCombobox />` component

Open Administrator requested to merge vk/add-multi-combobox-for-code-insights into main

Created by: vovakulikov

Background

A few code insights pages already have something like the Combobox component but instead of Combobox, they use something similar. A good example of it can be search-based insight creation UI (the repositories field).

Code insights creation UI search repositories field image

This field uses just a simple input with some logic on top of it. This logic is complex and sometimes when you work with simple text to manage a few items in this field (a few repositories) it can be complicated for users and can lead to some bugs there.

Also, Multibox would be useful for further change in the creation UI form when we start implementation of the new dashboards settings section in the form.

This PR adds the MultiCombobox component but doesn't add this to the creation UI. It will be done in a separate PR.

Light theme Dark theme
Screenshot 2021-10-07 at 17 25 03 Screenshot 2021-10-07 at 17 25 17

Work in progress but not blockers for design review

  1. A11y support (labels, focus management)
  2. Overflow content checks

Merge request reports

Approval is optional
The source branch vk/add-multi-combobox-for-code-insights does not exist. Please restore it or use a different source branch.

Merge details

  • 6 commits and 1 merge commit will be added to main.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading