Skip to content
Snippets Groups Projects

batches: select changesets, publication state from preview

Merged Administrator requested to merge kr/publish-from-preview into main

Created by: courier-new

Part 1 of #23383 (closed). Portions of this lifted from or inspired by #22658.

Note: This PR is temporarily based on #23960 since it copies the same pattern fixed there.

This PR includes:

  • some light cleanup/followup to #23821
  • selecting the preview changesets
  • selecting the desired publish status from a dropdown

image

This PR does not include:

  • recalculating the actions on the backend when a publish status modification is selected
  • applying the new publish statuses when you click "Apply"
  • disabling the "Apply" button until a publish status modification is selected

(Those will each be a follow-up PR, but this one I think is the chunkiest)

This absolutely duplicates a lot of code between BatchChangeChangesets and PreviewList, but I was not feeling particularly motivated to refactor it because

  1. we're trying to get this out sooner rather than later
  2. it's only duplicated across 2 places, not 3 or 4 or 5 or 10
  3. we're slowly moving towards getting rid of the preview page anyway

Merge request reports

Approval is optional
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading