Skip to content
Snippets Groups Projects

gitserver: Abort doBackgroundRepoUpdate when rate limiter is zero

Closed Administrator requested to merge core/abort-doBackgroundRepoUpdate into main

Created by: ryanslade

If we don't abort then the background job can potentially block forever if a zero rate limit has been set. This would leak goroutines and hold a cloneLimiter lock.

We do not add a timeout as it's hard to pick on as this is a legitimate background process that could take a long time to complete for large repos.

Closes: https://github.com/sourcegraph/sourcegraph/issues/19720

Merge request reports

Closed by avatar (Jul 5, 2025 4:13pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading