Skip to content
Snippets Groups Projects

server: Use include directives for nginx to create an upgrade path

Merged Administrator requested to merge includes into master

Created by: keegancsmith

We currently generate the nginx.conf for users, but then it is controlled by users. If we want to change a setting in nginx.conf (such as changing a proxy timeout), we then have to rely on user instructions to update the config.

Instead we can hook into the config via well placed include directives.

Also included in this PR is using go-bindata to embed config into server. This is to simplify the addition of the extra configs.

Fixes https://github.com/sourcegraph/sourcegraph/issues/1901

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading