Skip to content
Snippets Groups Projects

db: remove references to dbconn in store tests

Created by: asdine

This removes all calls to dbconn.Global and dbtesting.SetupGlobalTestDB (except one, I need to migrate the globalstatedb package first) from the internal/db package.

Merge request reports

Approval is optional

Merged by avatar (Sep 20, 2025 4:22am UTC)

Merge details

  • Changes merged into main with 23a782eb.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff eeb83e10f1085054b21af7b69c304337cbfa63fb...23a782eb70ed33a2951846e9f8f0dc19a3382683.

    Notify File(s)
    @LawnGnome internal/db/external_accounts.go
    internal/db/external_accounts_test.go
    internal/db/external_services.go
    internal/db/external_services_test.go
    internal/db/namespaces_test.go
    internal/db/repos.go
    internal/db/repos_db_test.go
    internal/db/repos_perm.go
    internal/db/repos_perm_test.go
    internal/db/repos_test.go
    @efritz internal/db/dbtesting/dbtesting.go
    @eseliger internal/db/external_accounts.go
    internal/db/external_accounts_test.go
    internal/db/external_services.go
    internal/db/external_services_test.go
    internal/db/namespaces_test.go
    internal/db/repos.go
    internal/db/repos_db_test.go
    internal/db/repos_perm.go
    internal/db/repos_perm_test.go
    internal/db/repos_test.go
    @unknwon internal/db/repos_perm.go
    internal/db/repos_perm_test.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #17511 (23a782e) into main (eeb83e1) will decrease coverage by 0.02%. The diff coverage is 72.22%.

    @@            Coverage Diff             @@
    ##             main   #17511      +/-   ##
    ==========================================
    - Coverage   51.73%   51.70%   -0.03%     
    ==========================================
      Files        1717     1717              
      Lines       85364    85364              
      Branches     7719     7719              
    ==========================================
    - Hits        44160    44140      -20     
    - Misses      37320    37324       +4     
    - Partials     3884     3900      +16     
    Flag Coverage Δ *Carryforward flag
    go 50.64% <72.22%> (-0.04%) :arrow_down:
    integration 30.68% <ø> (ø) Carriedforward from eeb83e1
    storybook 30.34% <ø> (ø) Carriedforward from eeb83e1
    typescript 54.26% <ø> (ø) Carriedforward from eeb83e1
    unit 34.67% <ø> (ø) Carriedforward from eeb83e1

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    internal/db/orgs.go 47.72% <0.00%> (-0.76%) :arrow_down:
    internal/db/phabricator.go 0.00% <0.00%> (ø)
    internal/db/users.go 50.63% <0.00%> (-0.22%) :arrow_down:
    internal/db/default_repos.go 47.61% <100.00%> (-2.39%) :arrow_down:
    internal/db/external_accounts.go 63.23% <100.00%> (-0.99%) :arrow_down:
    internal/db/external_services.go 66.90% <100.00%> (-0.24%) :arrow_down:
    internal/db/org_members.go 54.16% <100.00%> (-1.39%) :arrow_down:
    internal/db/repos.go 70.37% <100.00%> (-0.33%) :arrow_down:
    internal/db/repos_perm.go 90.90% <100.00%> (ø)
    internal/db/saved_searches.go 64.78% <100.00%> (-0.47%) :arrow_down:
    ... and 17 more
Please register or sign in to reply
Loading