db: Add cloud_default column to external_services

Created by: ryanslade

I'm still not convinced about the name. Maybe cloud_public is better? cloud_default?

Went with cloud_default ️

The intention is to indicate that the external service is our default public external service for on-demand syncing and cloning.

Part of: https://github.com/sourcegraph/sourcegraph/issues/17472

Created by: sourcegraph-bot

Notifying subscribers in CODENOTIFY files for diff f8e5c59b1a721cc7c892e40ff4d878bcf29c1daa...4e907b75df3517b0387904c0d76222537f2166fc.

Notify	File(s)
@LawnGnome	internal/db/external_services.go
@asdine	internal/db/external_services.go
@eseliger	internal/db/external_services.go

Created by: codecov[bot]

Codecov Report

Merging #17501 (4e907b7) into main (0e3a2c2) will increase coverage by 0.00%. The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main   #17501   +/-   ##
=======================================
  Coverage   51.70%   51.70%           
=======================================
  Files        1717     1717           
  Lines       85318    85320    +2     
  Branches     7757     7667   -90     
=======================================
+ Hits        44110    44112    +2     
+ Misses      37327    37326    -1     
- Partials     3881     3882    +1     

Flag	Coverage Δ
go	50.64% <83.33%> (-0.01%)
integration	30.68% <ø> (+0.01%)
storybook	30.33% <ø> (ø)
typescript	54.26% <ø> (+<0.01%)
unit	34.67% <ø> (ø)

Impacted Files	Coverage Δ
internal/db/external_services.go	67.13% <83.33%> (+0.15%)
.../internal/codeintel/resolvers/graphql/locations.go	83.50% <0.00%> (-2.07%)
client/web/src/tree/TreeRoot.tsx	86.36% <0.00%> (+3.03%)

Created by: ryanslade

LGTM I like cloud_default better though, but not a blocker

Yeah, I think that might be the best option. I'd rather make the change now than need to add another migration to rename everything