Skip to content
Snippets Groups Projects

Delete the secrets store

Created by: asdine

Fixes https://github.com/sourcegraph/sourcegraph/issues/15862

This store is no longer used though, should we remove it? cc @unknwon @chayim

Merge request reports

Approval is optional

Merged by avatar (Sep 22, 2025 8:47pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #17458 (c610ab7) into main (0197ed6) will decrease coverage by 0.03%. The diff coverage is n/a.

    @@            Coverage Diff             @@
    ##             main   #17458      +/-   ##
    ==========================================
    - Coverage   51.92%   51.89%   -0.04%     
    ==========================================
      Files        1716     1715       -1     
      Lines       85218    85076     -142     
      Branches     7749     7749              
    ==========================================
    - Hits        44250    44148     -102     
    + Misses      37066    37046      -20     
    + Partials     3902     3882      -20     
    Flag Coverage Δ *Carryforward flag
    go 50.88% <ø> (-0.05%) :arrow_down:
    integration 30.64% <ø> (ø) Carriedforward from 94cf5e2
    storybook 30.34% <ø> (ø) Carriedforward from 94cf5e2
    typescript 54.32% <ø> (ø) Carriedforward from 94cf5e2
    unit 34.72% <ø> (ø) Carriedforward from 94cf5e2

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    .../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+4.12%) :arrow_up:
  • Created by: tsenart

    Yeah, if this isn't used let's nuke it.

Please register or sign in to reply
Loading