Skip to content
Snippets Groups Projects

basestore: Use Exec and add ExecResult

Created by: ryanslade

Execute Exec on the handle when calling basestore.Exec. Also, add a new ExecResult which included the sql.Result when Exec is run. A new method was added instead of amending the old one to reduce refactoring noise. Most of the time we are not interested in the result.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff 79a2a38c61ca533c859be9835f22c6c59beb62a2...55ea05ea2fc3191644d50da7bebbe5f6a5e429e7.

    Notify File(s)
    @efritz internal/db/basestore/store.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #17160 (55ea05e) into main (79a2a38) will increase coverage by 0.00%. The diff coverage is 100.00%.

    @@           Coverage Diff           @@
    ##             main   #17160   +/-   ##
    =======================================
      Coverage   48.95%   48.95%           
    =======================================
      Files        1710     1710           
      Lines       84478    84477    -1     
      Branches     7649     7649           
    =======================================
    + Hits        41357    41359    +2     
    + Misses      39220    39219    -1     
    + Partials     3901     3899    -2     
    Flag Coverage Δ *Carryforward flag
    go 51.31% <100.00%> (+<0.01%) :arrow_up:
    storybook 28.94% <ø> (ø) Carriedforward from 79a2a38
    typescript 43.39% <ø> (ø) Carriedforward from 79a2a38
    unit 35.05% <ø> (ø) Carriedforward from 79a2a38

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    internal/db/basestore/store.go 42.10% <100.00%> (+2.10%) :arrow_up:
    .../internal/codeintel/resolvers/graphql/locations.go 85.56% <0.00%> (+2.06%) :arrow_up:
  • Created by: ryanslade

    Merging without review as the changes are minimal, all tests pass and I need this change for another PR

Please register or sign in to reply
Loading