repo-updater: always wrap context.Background with internal actor
Created by: unknwon
repo-updater used to have god-view of the entire repo table, but with the merge of underlying DB logic, the repoStore it is using now respecting the repository permissions, which makes the repo-updater not able to see the private repos anymore.
This causes two symptoms (maybe there are more):
- Permissions syncing stops working because it can't see private repos (no leakage, instead non-admin could see nothing).
- Site admin can still visit the private repo on Sourcegraph but not able to view the settings page, because the page sends a request to the repo-updater and the latter couldn't see it.

I found this bug in my personal instance, triggered by my recent update to insider version, and my friend couldn't see my repo anymore
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #17149 (c145f95) into main (763864f) will decrease coverage by
0.00%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## main #17149 +/- ## ========================================== - Coverage 52.17% 52.16% -0.01% ========================================== Files 1710 1710 Lines 84450 84449 -1 Branches 7817 7817 ========================================== - Hits 44062 44057 -5 - Misses 36487 36492 +5 + Partials 3901 3900 -1
Flag Coverage Δ *Carryforward flag go 51.31% <ø> (-0.01%)
integration 29.86% <ø> (ø)
Carriedforward from af2ad20 storybook 28.94% <ø> (ø)
Carriedforward from af2ad20 typescript 54.19% <ø> (ø)
Carriedforward from af2ad20 unit 35.05% <ø> (ø)
Carriedforward from af2ad20 *This pull request uses carry forward flags. Click here to find out more.
Impacted Files Coverage Δ enterprise/cmd/repo-updater/authz/perms_syncer.go 42.26% <ø> (-0.15%)
.../internal/codeintel/resolvers/graphql/locations.go 83.50% <0.00%> (-2.07%)
...nal/campaigns/resolvers/changeset_apply_preview.go 58.97% <0.00%> (-1.71%)
Please register or sign in to reply