Skip to content
Snippets Groups Projects

Don't enqueue unpublished changeset for closing

Merged Administrator requested to merge es/no-close-unpublished into main

Created by: eseliger

Currently, this query matches unpublished changesets and they would get enqueued with Closing: true. The reconciler would actually attempt that then and (hopefully) fails. We should ideally never enqueue them, so this PR fixes that.

Merge request reports

Merged by avatar (Jul 26, 2025 3:33am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff f15c904291c085a50438e5ec845cf98f7687c447...0cfd8f77d1b21b5a2575f08244dda8e8b92e5b2f.

    Notify File(s)
    @LawnGnome enterprise/internal/campaigns/store/changesets.go
    enterprise/internal/campaigns/store/changesets_test.go
  • Created by: codecov[bot]

    Codecov Report

    Merging #16910 (0cfd8f7) into main (f15c904) will increase coverage by 0.00%. The diff coverage is 100.00%.

    @@           Coverage Diff           @@
    ##             main   #16910   +/-   ##
    =======================================
      Coverage   45.43%   45.43%           
    =======================================
      Files        1443     1443           
      Lines       73890    73892    +2     
      Branches     4888     4888           
    =======================================
    + Hits        33571    33573    +2     
      Misses      36454    36454           
      Partials     3865     3865           
    Flag Coverage Δ *Carryforward flag
    go 51.36% <100.00%> (+<0.01%) :arrow_up:
    typescript 21.56% <ø> (ø) Carriedforward from f15c904
    unit 21.56% <ø> (ø) Carriedforward from f15c904

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    enterprise/internal/campaigns/store/changesets.go 83.23% <100.00%> (+0.10%) :arrow_up:
Please register or sign in to reply
Loading