Merge unsynced and publication state together

Created by: eseliger

Unsynced can actually be derived from publication state, so why have two different ways for branch and imported changesets. This PR merges the two into a unified solution, making the publication state the single source of truth. Also, this makes more sense with the default value we have for the column in the database.

Created by: sourcegraph-bot

Notifying subscribers in CODENOTIFY files for diff b019aa1c465aa38df795725fb9319bca8ff1c42d...e36f46e9c81b2efde44c54e678c580ccc79ffc35.

Notify

File(s)

@LawnGnome

enterprise/internal/campaigns/reconciler/executor.go enterprise/internal/campaigns/reconciler/executor_test.go enterprise/internal/campaigns/reconciler/plan.go enterprise/internal/campaigns/resolvers/campaign.go enterprise/internal/campaigns/resolvers/changeset.go enterprise/internal/campaigns/resolvers/changeset_test.go enterprise/internal/campaigns/rewirer/rewirer.go enterprise/internal/campaigns/service/service_apply_campaign_test.go enterprise/internal/campaigns/store/changesets.go enterprise/internal/campaigns/store/changesets_test.go enterprise/internal/campaigns/syncer/syncer.go enterprise/internal/campaigns/testing/changeset.go internal/campaigns/changeset.go

Created by: codecov[bot]

Codecov Report

Merging #16860 (e36f46e) into main (b019aa1) will decrease coverage by 0.01%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main   #16860      +/-   ##
==========================================
- Coverage   52.28%   52.26%   -0.02%     
==========================================
  Files        1698     1698              
  Lines       83921    83914       -7     
  Branches     7630     7788     +158     
==========================================
- Hits        43874    43861      -13     
- Misses      36178    36184       +6     
  Partials     3869     3869              

Flag	Coverage Δ
go	51.36% <77.77%> (-0.02%)
integration	29.67% <ø> (-0.02%)
storybook	28.74% <ø> (ø)
typescript	54.39% <ø> (-0.01%)
unit	35.03% <ø> (ø)

Impacted Files	Coverage Δ
enterprise/internal/campaigns/reconciler/plan.go	64.75% <0.00%> (ø)
enterprise/internal/campaigns/store/changesets.go	83.13% <0.00%> (-0.21%)
enterprise/internal/campaigns/syncer/syncer.go	61.71% <ø> (+0.27%)
internal/campaigns/changeset.go	49.74% <ø> (+0.12%)
...terprise/internal/campaigns/resolvers/changeset.go	68.93% <81.81%> (ø)
...terprise/internal/campaigns/reconciler/executor.go	64.74% <100.00%> (ø)
...nterprise/internal/campaigns/resolvers/campaign.go	77.58% <100.00%> (-0.20%)
client/web/src/settings/SettingsPage.tsx	64.70% <0.00%> (-11.77%)
.../internal/codeintel/resolvers/graphql/locations.go	79.38% <0.00%> (-4.13%)
...nal/campaigns/resolvers/changeset_apply_preview.go	58.97% <0.00%> (-1.71%)

Created by: eseliger

Hmm. I see what you mean I thought about it as "the spec is published by the reconciler", not really in relation to the changeset state. I think the naming of this column is a little.. misleading, as we still use it for two purposes, which shouldn't be, probably. !16863 (merged) which is stacked on top of this one removes it from the GraphQL API entirely, so maybe we can consider renaming it even. I just don't have any creative ideas (as always when it comes to naming things..)

Created by: eseliger

I'm going to merge this for now, I'll keep thinking about how this might be improved going forward.