Skip to content
Snippets Groups Projects

authz: simplify PermsStore with intarray

Merged Administrator requested to merge jc/simplify-permsStore-intarray into main

Created by: unknwon

Our permissions storage format in Postgres has been transitioned from roaring bitmap (BYTEA) to intarray ([]INT), it is now possible to perform many operations directly using SQLs.

I rely on our tests to ensure correctness, and tested end-to-end.

Easier to be reviewed with split view

Fixes #11768

Merge request reports

Approval is optional

Merged by avatar (Jul 26, 2025 9:10am UTC)

Merge details

  • Changes merged into main with 804f08f6.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #16003 (804f08f) into main (1c21a3d) will decrease coverage by 0.05%. The diff coverage is 82.79%.

    @@            Coverage Diff             @@
    ##             main   #16003      +/-   ##
    ==========================================
    - Coverage   52.79%   52.74%   -0.06%     
    ==========================================
      Files        1643     1643              
      Lines       82544    82418     -126     
      Branches     7270     7270              
    ==========================================
    - Hits        43581    43471     -110     
    + Misses      35081    35073       -8     
    + Partials     3882     3874       -8     
    Flag Coverage Δ *Carryforward flag
    go 52.59% <82.79%> (-0.08%) :arrow_down:
    integration 28.57% <ø> (ø) Carriedforward from 08077e8
    storybook 27.85% <ø> (ø) Carriedforward from 08077e8
    typescript 53.11% <ø> (ø) Carriedforward from 08077e8
    unit 35.47% <ø> (ø) Carriedforward from 08077e8

    *This pull request uses carry forward flags. Click here to find out more.

    Impacted Files Coverage Δ
    enterprise/internal/db/perms_store.go 77.88% <82.79%> (-1.24%) :arrow_down:
  • Created by: unknwon

    Merging as-is, @flying-robot when you're back, feel free to leave feedback here or drop an event on my calendar.

Please register or sign in to reply
Loading