graphqlbackend: More lazy loading of git commits (!15971) · Merge requests · Administrator / sourcegraph

Administrator requested to merge cloud/more-lazy-commit-loading into main Nov 19, 2020

Created by: tsenart

This changeset builds on top of #15752 to extend lazy loading of git commits to these code paths:

graphqlbackend.RepositoryResolver.{Commit, CommitFromID}
graphqlbackend.NewRepositoryComparison

As per what we observed in getCommits data set in Honeycomb, most of the GraphQL queries using the gitCommitResolver, either directly or indirectly, don't ask for information beyond the commit ID or URL, which can be constructed statically without calling out to git-server to run an expensive git log operation.

This change also makes it so the above code paths don't trigger any lazy adding of repos that are being seen for the first time, which on sourcegraph.com wasn't happening anyways, and on customer instances isn't needed, since we know the repos we have at hand already do exist in the repo table.

This doesn't change the behaviour of ensuring a revision exists when running a git command (like git log).

These are client calls that should see speed improvements from having at least -1 RPCs to gitserver:

These code paths are so pervasive, that this should result in a slight to significant (depending on the specific client call) performance improvement across the whole product. We'll be able to monitor the performance of these GraphQL queries with the internal dashboard checked-in with this PR (cc @bobheadxi @pecigonzalo).

This also fixes #15392 for good (for now).

graphqlbackend: More lazy loading of git commits

Merge request reports