Skip to content

search: remove quote hint in regex mode if pattern contains colon

Administrator requested to merge rvt/no-quotes-hint-for-regexp into main

Created by: rvantonder

In favor of removing this. It's related to improving other quoting hints, which I'll get to later (https://github.com/sourcegraph/sourcegraph/issues/12802, https://github.com/sourcegraph/sourcegraph/issues/10793, https://github.com/sourcegraph/sourcegraph/issues/11909).

As in: I half-know what I’m doing here by using regex. I appreciate the hint though, when I use it the first time.

I don't think there's any way to make this dismissible. The usefulness showing this on first time is outweighed by this showing up every time, and regex is an opt-in toggle, so we can mostly safely assume the user knows what they're dealing with.

Context:

Screen Shot 2020-10-26 at 8 50 28 AM

Merge request reports

Loading