campaigns: fix icon display on navbars
Created by: LawnGnome
As reported by @bobheadxi, both the global and namespace navbars were using subtly (or not so subtly) incorrect versions of the campaigns icon. This metaphorically aligns them with the intended versions, and also adds the required viewbox tweaks to literally align them with the other icons in their respective navbars.
Merge request reports
Activity
Created by: sourcegraph-bot
Notifying subscribers in CODENOTIFY files for diff 22f1692018c738089655b3e4cd48fc067ffc5dab...ad63a317200cfe6ac7b718927dd1555e4f5a2dd3.
Notify File(s) @eseliger client/web/src/enterprise/campaigns/global/nav/CampaignsNavItem.tsx
client/web/src/enterprise/campaigns/global/nav/snapshots/CampaignsNavItem.test.tsx.snap
client/web/src/enterprise/campaigns/icons.tsxCreated by: codecov[bot]
Codecov Report
Merging #14967 into main will increase coverage by
0.00%
. The diff coverage is100.00%
.@@ Coverage Diff @@ ## main #14967 +/- ## ======================================= Coverage 52.12% 52.13% ======================================= Files 1556 1556 Lines 79501 79503 +2 Branches 7146 7078 -68 ======================================= + Hits 41443 41445 +2 Misses 34312 34312 Partials 3746 3746
Flag Coverage Δ #go 52.30% <ø> (ø)
#integration 30.34% <100.00%> (+<0.01%)
#storybook 22.18% <90.00%> (+0.01%)
#typescript 51.69% <100.00%> (+<0.01%)
#unit 33.91% <90.00%> (+<0.01%)
Impacted Files Coverage Δ ...terprise/campaigns/global/nav/CampaignsNavItem.tsx 100.00% <ø> (ø)
client/web/src/enterprise/namespaces/navitems.ts 100.00% <ø> (ø)
client/web/src/enterprise/campaigns/icons.tsx 100.00% <100.00%> (ø)
client/web/src/settings/SettingsFile.tsx 70.65% <0.00%> (-1.09%)
...t/web/src/search/input/interactive/FilterInput.tsx 89.61% <0.00%> (+0.64%)
Please register or sign in to reply