Remove Campaigns beta flag
Created by: mrnugget
This removes the beta flag from campaign.
Yesterday, in a discussion with Chris, Quinn S., Christina and Rob we decided that we shouldn't keep pushing that "remove beta-flag"-milestone in front of us.
We think the product is ready to be used by more customers and our primary goal is to grow adoption. That means it's no longer in beta.
Of course we'll still iterate and refine and improve campaigns, that's out of the question.
So, let's get rid of this artificial barrier and milestone and focus on the actual goal: getting campaigns into the hands of more customers.
Merge request reports
Activity
Created by: sourcegraph-bot
Notifying subscribers in CODENOTIFY files for diff 3412c0ccdc716a8768570afe1334b849d8a5bdec...92965a6da89e1a6f9b85d9329a9cbcf4129a5466.
Notify File(s) @eseliger client/web/src/enterprise/campaigns/create/CreateCampaignPage.tsx
client/web/src/enterprise/campaigns/detail/CampaignHeader.tsx
client/web/src/enterprise/campaigns/detail/snapshots/CampaignDetailsPage.test.tsx.snap
client/web/src/enterprise/campaigns/global/marketing/CampaignsDotComPage.tsx
client/web/src/enterprise/campaigns/global/marketing/snapshots/CampaignsDotComPage.test.tsx.snap
client/web/src/enterprise/campaigns/icons.tsx
client/web/src/enterprise/campaigns/list/CampaignListPage.tsx
client/web/src/enterprise/campaigns/list/CampaignsListBetaNotice.scss
client/web/src/enterprise/campaigns/list/CampaignsListBetaNotice.story.tsx
client/web/src/enterprise/campaigns/list/CampaignsListBetaNotice.tsx
client/web/src/enterprise/campaigns/list/snapshots/CampaignListPage.test.tsx.snapCreated by: codecov[bot]
Codecov Report
Merging #14900 into main will decrease coverage by
0.00%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## main #14900 +/- ## ========================================== - Coverage 52.18% 52.18% -0.01% ========================================== Files 1555 1554 -1 Lines 79479 79475 -4 Branches 7163 7149 -14 ========================================== - Hits 41478 41474 -4 + Misses 34258 34257 -1 - Partials 3743 3744 +1
Flag Coverage Δ #go 52.35% <ø> (-0.01%)
#integration 30.50% <ø> (-0.02%)
#storybook 22.14% <ø> (-0.03%)
#typescript 51.76% <ø> (-0.01%)
#unit 33.69% <ø> (-0.01%)
Impacted Files Coverage Δ ...enterprise/campaigns/create/CreateCampaignPage.tsx 78.57% <ø> (ø)
...src/enterprise/campaigns/detail/CampaignHeader.tsx 100.00% <ø> (ø)
...campaigns/global/marketing/CampaignsDotComPage.tsx 100.00% <ø> (ø)
client/web/src/enterprise/campaigns/icons.tsx 100.00% <ø> (ø)
...src/enterprise/campaigns/list/CampaignListPage.tsx 100.00% <ø> (ø)
...prise/cmd/frontend/auth/httpheader/config_watch.go 50.00% <0.00%> (-33.34%)
...t/web/src/search/input/interactive/FilterInput.tsx 89.61% <0.00%> (+0.64%)
...nterprise/cmd/frontend/auth/httpheader/provider.go 20.00% <0.00%> (+20.00%)
Created by: mrnugget
LGTM. I did a quick search and didn't find any, but is it actually true that the docs don't have a single mention of beta on campaigns?
Yep. Another reason to get rid of the badge here.