campaigns: add new icon
Merge request reports
Activity
Created by: sourcegraph-bot
Notifying subscribers in CODENOTIFY files for diff d6b564a9e990d0c4bbbd491b161136deac2f8082...890389a4464ca0006eb1c1ebd143de1ddc75b68d.
Notify File(s) @christinaforney doc/campaigns/campaigns-icon.svg @eseliger client/web/src/enterprise/campaigns/create/CreateCampaignPage.tsx
client/web/src/enterprise/campaigns/detail/CampaignHeader.tsx
client/web/src/enterprise/campaigns/detail/snapshots/CampaignDetailsPage.test.tsx.snap
client/web/src/enterprise/campaigns/global/marketing/CampaignsDotComPage.tsx
client/web/src/enterprise/campaigns/global/marketing/snapshots/CampaignsDotComPage.test.tsx.snap
client/web/src/enterprise/campaigns/global/nav/snapshots/CampaignsNavItem.test.tsx.snap
client/web/src/enterprise/campaigns/icons.tsx
client/web/src/enterprise/campaigns/list/CampaignListPage.tsx
client/web/src/enterprise/campaigns/list/snapshots/CampaignListPage.test.tsx.snapCreated by: codecov[bot]
Codecov Report
Merging #14740 into main will increase coverage by
0.00%
. The diff coverage is100.00%
.@@ Coverage Diff @@ ## main #14740 +/- ## ======================================== Coverage 52.19% 52.20% ======================================== Files 1556 1556 Lines 79508 79513 +5 Branches 6977 7132 +155 ======================================== + Hits 41503 41508 +5 Misses 34256 34256 Partials 3749 3749
Flag Coverage Δ #go 52.39% <ø> (ø)
#integration 30.37% <100.00%> (+0.03%)
#storybook 22.19% <87.50%> (+0.02%)
#typescript 51.72% <100.00%> (+0.01%)
#unit 33.92% <87.50%> (+0.01%)
Impacted Files Coverage Δ ...enterprise/campaigns/create/CreateCampaignPage.tsx 78.57% <ø> (ø)
...src/enterprise/campaigns/detail/CampaignHeader.tsx 100.00% <ø> (ø)
...campaigns/global/marketing/CampaignsDotComPage.tsx 100.00% <ø> (ø)
...src/enterprise/campaigns/list/CampaignListPage.tsx 100.00% <ø> (ø)
client/web/src/enterprise/namespaces/navitems.ts 100.00% <ø> (ø)
client/web/src/enterprise/campaigns/icons.tsx 100.00% <100.00%> (ø)
client/web/src/nav/StatusMessagesNavItem.tsx 85.96% <0.00%> (-1.76%)
client/web/src/tree/TreeRoot.tsx 81.03% <0.00%> (+1.72%)
Created by: AlicjaSuska
@LawnGnome thank you for creating this issue. Actually, it seems like we should move forward with this one as:
- it feels the most 'refined'
- it doesn't indicate the flow, all arrows and squares feel equally important
I've prepared the svg export - icon in the 20px bounding box - standard for all our icons :) You can download it from the google drive or export directly from Figma. Please, scale the size accordingly for the header.
Created by: mrnugget
Haha, I swear I head nothing to do with this
@AlicjaSuska we had a discussion about which logo to choose and I agree with you — I like how the arrows give it a dynamic and show that one thing does something that leads to multiple other things. @eseliger and @LawnGnome wanted to use the other one.
Created by: AlicjaSuska
Ok, in this case let's move forward with the first choice :)
Exports:
- 20px bounding box svg (used in the nav bar): Figma
- header icon (32px bonding box, different proportions) - Figma
I've recorded the loom video on how to export from Figma, if needed :) Looking forward to those updates!
Created by: AlicjaSuska
It looks a little 'skinny' in the small size, especially the lines. I didn't realize it in Figma before
. I made it a little bolder. Please, let me know what do you think about it. Comparison:Comparison with the standard mdi icon
Links (if moving forward with the bolder version) Updated Figma export 20px Updated header icon
Created by: LawnGnome
Updated with the newest icon revision.
Can you also update it in the docs? https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+campaigns-icon.svg+f:doc&patternType=regexp
Done.