Skip to content
Snippets Groups Projects

campaigns: add new icon

Merged Administrator requested to merge aharvey/campaign-icon into main

Created by: LawnGnome

Here's how this now looks, after @AlicjaSuska's hard work below (and helpful Loom video):

image

And, for the record, in dark mode:

image

Merge request reports

Approval is optional

Merged by avatar (Jul 26, 2025 8:11am UTC)

Merge details

  • Changes merged into with 890389a4.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: sourcegraph-bot

    Notifying subscribers in CODENOTIFY files for diff d6b564a9e990d0c4bbbd491b161136deac2f8082...890389a4464ca0006eb1c1ebd143de1ddc75b68d.

    Notify File(s)
    @christinaforney doc/campaigns/campaigns-icon.svg
    @eseliger client/web/src/enterprise/campaigns/create/CreateCampaignPage.tsx
    client/web/src/enterprise/campaigns/detail/CampaignHeader.tsx
    client/web/src/enterprise/campaigns/detail/snapshots/CampaignDetailsPage.test.tsx.snap
    client/web/src/enterprise/campaigns/global/marketing/CampaignsDotComPage.tsx
    client/web/src/enterprise/campaigns/global/marketing/snapshots/CampaignsDotComPage.test.tsx.snap
    client/web/src/enterprise/campaigns/global/nav/snapshots/CampaignsNavItem.test.tsx.snap
    client/web/src/enterprise/campaigns/icons.tsx
    client/web/src/enterprise/campaigns/list/CampaignListPage.tsx
    client/web/src/enterprise/campaigns/list/snapshots/CampaignListPage.test.tsx.snap
  • Created by: codecov[bot]

    Codecov Report

    Merging #14740 into main will increase coverage by 0.00%. The diff coverage is 100.00%.

    @@           Coverage Diff            @@
    ##             main   #14740    +/-   ##
    ========================================
      Coverage   52.19%   52.20%            
    ========================================
      Files        1556     1556            
      Lines       79508    79513     +5     
      Branches     6977     7132   +155     
    ========================================
    + Hits        41503    41508     +5     
      Misses      34256    34256            
      Partials     3749     3749            
    Flag Coverage Δ
    #go 52.39% <ø> (ø)
    #integration 30.37% <100.00%> (+0.03%) :arrow_up:
    #storybook 22.19% <87.50%> (+0.02%) :arrow_up:
    #typescript 51.72% <100.00%> (+0.01%) :arrow_up:
    #unit 33.92% <87.50%> (+0.01%) :arrow_up:
    Impacted Files Coverage Δ
    ...enterprise/campaigns/create/CreateCampaignPage.tsx 78.57% <ø> (ø)
    ...src/enterprise/campaigns/detail/CampaignHeader.tsx 100.00% <ø> (ø)
    ...campaigns/global/marketing/CampaignsDotComPage.tsx 100.00% <ø> (ø)
    ...src/enterprise/campaigns/list/CampaignListPage.tsx 100.00% <ø> (ø)
    client/web/src/enterprise/namespaces/navitems.ts 100.00% <ø> (ø)
    client/web/src/enterprise/campaigns/icons.tsx 100.00% <100.00%> (ø)
    client/web/src/nav/StatusMessagesNavItem.tsx 85.96% <0.00%> (-1.76%) :arrow_down:
    client/web/src/tree/TreeRoot.tsx 81.03% <0.00%> (+1.72%) :arrow_up:
  • Created by: AlicjaSuska

    @LawnGnome thank you for creating this issue. Actually, it seems like we should move forward with this one as:

    • it feels the most 'refined'
    • it doesn't indicate the flow, all arrows and squares feel equally important
    Screenshot 2020-10-15 at 09 28 41

    I've prepared the svg export - icon in the 20px bounding box - standard for all our icons :) You can download it from the google drive or export directly from Figma. Please, scale the size accordingly for the header.

  • Created by: mrnugget

    Haha, I swear I head nothing to do with this :smile:

    @AlicjaSuska we had a discussion about which logo to choose and I agree with you — I like how the arrows give it a dynamic and show that one thing does something that leads to multiple other things. @eseliger and @LawnGnome wanted to use the other one.

  • Created by: rrhyne

    I like all of the designs, but I think the selected version is the right call. The arrows in the other versions introduce readability issues at the size the icon will display and it's symmetry evokes too many connotations that are non-technical.

  • Created by: LawnGnome

    @AlicjaSuska @rrhyne We're happy with whatever y'all design experts think is best. Whatever that is, if we could please get a clean 20px SVG, that would be ideal!

  • Created by: AlicjaSuska

    Ok, in this case let's move forward with the first choice :)

    Exports:

    • 20px bounding box svg (used in the nav bar): Figma
    • header icon (32px bonding box, different proportions) - Figma

    I've recorded the loom video on how to export from Figma, if needed :) Looking forward to those updates! :tada:

  • Created by: LawnGnome

    Thanks, Alicja!

    This is now up to date, and ready for (hopefully) final review. (Note that someone should also go click the accept button on the Percy check; I suspect I'm not supposed to do that myself, but it looks right to me.)

  • Created by: AlicjaSuska

    It looks a little 'skinny' in the small size, especially the lines. I didn't realize it in Figma before :thinking:. I made it a little bolder. Please, let me know what do you think about it. Comparison:

    Currently Before

    Bolder After

    Comparison with the standard mdi icon Screenshot 2020-10-20 at 13 11 40

    Links (if moving forward with the bolder version) Updated Figma export 20px Updated header icon

  • Created by: LawnGnome

    Updated with the newest icon revision.

    Can you also update it in the docs? https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+campaigns-icon.svg+f:doc&patternType=regexp

    Done.

Please register or sign in to reply
Loading