Only take reconciled changesets into consideration when calculating events
Created by: eseliger
This fixes a bug where calculation would fail because ExternalCreatedAt is null, because it could not be synced initially. I think this makes sense, as we won't have consistent data before it's reconciled anyways, but please let's discuss!
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #14521 into main will increase coverage by
0.00%
. The diff coverage is100.00%
.@@ Coverage Diff @@ ## main #14521 +/- ## ======================================= Coverage 52.21% 52.22% ======================================= Files 1556 1556 Lines 79150 79155 +5 Branches 6947 6947 ======================================= + Hits 41330 41336 +6 + Misses 34084 34083 -1 Partials 3736 3736
Flag Coverage Δ *Carryforward flag #go 52.54% <100.00%> (+<0.01%)
#integration 30.79% <ø> (ø)
Carriedforward from a6543af #storybook 22.02% <ø> (ø)
Carriedforward from a6543af #typescript 51.44% <ø> (ø)
Carriedforward from a6543af #unit 33.23% <ø> (ø)
Carriedforward from a6543af *This pull request uses carry forward flags. Click here to find out more.
Impacted Files Coverage Δ ...nterprise/internal/campaigns/resolvers/campaign.go 78.37% <100.00%> (+0.60%)
enterprise/internal/campaigns/store_changesets.go 83.43% <100.00%> (+0.10%)
internal/db/helpers.go 100.00% <0.00%> (ø)
internal/gosrc/stdlib.go 100.00% <0.00%> (ø)
internal/conf/platform.go 100.00% <0.00%> (ø)
internal/routevar/util.go 100.00% <0.00%> (ø)
internal/timeutil/week.go 100.00% <0.00%> (ø)
internal/vcs/git/mocks.go 100.00% <0.00%> (ø)
internal/db/query/query.go 100.00% <0.00%> (ø)
internal/highlight/mocks.go 100.00% <0.00%> (ø)
... and 765 more
Please register or sign in to reply