Don't skip pipelines and notes already seen
Created by: eseliger
This optimization caused problems, because we cannot ensure that resources beyond that timestamp never get updated, and in fact, they do. Hence the Pipelines would never get into their final state, because a refetch would not happen. Also, there were some state mappings missing in the GitlabPipelineState -> ChangesetCheckstate conversion.
Closes https://github.com/sourcegraph/sourcegraph/issues/12667
Merge request reports
Activity
Created by: sourcegraph-bot
Notifying subscribers in CODENOTIFY files for diff 5e93283020a4185d8ba63a59e9494f3a66a5423e...e761dcacbb17462999ef0b5714936dd89793e61a.
Notify File(s) @eseliger enterprise/internal/campaigns/state.go Created by: codecov[bot]
Codecov Report
Merging #14129 into main will decrease coverage by
1.74%
. The diff coverage is100.00%
.@@ Coverage Diff @@ ## main #14129 +/- ## ========================================== - Coverage 51.32% 49.57% -1.75% ========================================== Files 1525 1511 -14 Lines 77188 76560 -628 Branches 6943 6829 -114 ========================================== - Hits 39616 37955 -1661 - Misses 33999 35036 +1037 + Partials 3573 3569 -4
Flag Coverage Δ #go 51.65% <100.00%> (-0.01%)
#integration 29.17% <ø> (ø)
#storybook 18.26% <ø> (ø)
#typescript 44.49% <ø> (-6.01%)
#unit 31.25% <ø> (-2.67%)
Impacted Files Coverage Δ cmd/repo-updater/repos/gitlab.go 81.63% <100.00%> (-1.00%)
enterprise/internal/campaigns/state.go 77.91% <100.00%> (ø)
browser/src/shared/code-hosts/shared/consts.ts 0.00% <0.00%> (-100.00%)
browser/src/shared/code-hosts/github/tooltip.ts 0.00% <0.00%> (-100.00%)
browser/src/shared/code-hosts/gitlab/extensions.ts 0.00% <0.00%> (-100.00%)
...rowser/src/shared/code-hosts/github/extensions.tsx 0.00% <0.00%> (-100.00%)
...er/src/shared/backend/extension-api-conversion.tsx 0.00% <0.00%> (-100.00%)
...r/src/browser-extension/web-extension-api/types.ts 0.00% <0.00%> (-100.00%)
browser/src/shared/code-hosts/shared/views.ts 0.00% <0.00%> (-98.04%)
.../src/shared/code-hosts/shared/codeHostTestUtils.ts 0.00% <0.00%> (-95.24%)
... and 66 more
Please register or sign in to reply