Replace CODEOWNERS with CODENOTIFY
Created by: nicksnyder
Background
This PR replaces https://github.com/sourcegraph/sourcegraph/pull/11718.
For reasons mentioned in that other PR, I suspect that we would be better off not using CODEOWNERS.
The anonymous survey indicates that the dev team agrees:
Source: https://docs.google.com/forms/d/e/1FAIpQLSfjDJxP1wdfEuTZdeNqTsCxfXD2HIYx_5aiTC17B6LyXwYorw/viewanalytics
The biggest concern was devs not being notified of changes that they care about.
This PR
This PR is the beginning of two related, but independent, experiments:
- We are not going to use CODEOWNERS for the rest of September, and October.
- I have created a tool called codenotify which aims to address the use case of allowing devs to be notified of changes that they care about (without creating the expectation of review). After this is merged, devs can experiment with adding CODENOTIFY files. Feedback on the behavior of codenotify is obviously welcome at any time.
At the end of October I will send out a survey to see how the team feels after living with these changes for a full release cycle.
Valid outcomes of this experiment include:
- Everyone hates this and we go back to using only CODEOWNERS.
- Devs find value in codenotify but want to use CODEOWNERS as well in some cases.
- Devs are happy to only use codenotify and keep CODEOWNERS empty.
Given the data already collected in the previous survey, and my conviction that this is worth trying, I plan on merging this tomorrow.
Merge request reports
Activity
Created by: bobheadxi
A few super minor nits about codenotify:
- could the bot not post a comment if there are no notifications? (ie in the comment above)
- CODENOFITY all caps is a bit of an aggressive header
- A footer with a link to how to subscribe to notifications might be helpful, eg:
Want notifications for changes to these files? Add a CODENOTIFY.
Created by: nicksnyder
Thanks for the feedback @bobheadxi! I addressed it here: https://github.com/sourcegraph/codenotify/compare/v0.1...v0.2
You can see what a rendered report looks like in the updated readme: https://github.com/sourcegraph/codenotify#github-action
Created by: codecov[bot]
Codecov Report
Merging #13838 into main will decrease coverage by
0.00%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## main #13838 +/- ## ========================================== - Coverage 52.06% 52.06% -0.01% ========================================== Files 1514 1514 Lines 84214 84214 Branches 6863 6968 +105 ========================================== - Hits 43849 43844 -5 - Misses 36745 36751 +6 + Partials 3620 3619 -1
Flag Coverage Δ #go 52.64% <ø> (+<0.01%)
#integration 29.07% <ø> (-0.08%)
#storybook 18.23% <ø> (ø)
#typescript 50.49% <ø> (-0.04%)
#unit 33.92% <ø> (ø)
Impacted Files Coverage Δ web/src/tree/TreeRoot.tsx 81.03% <0.00%> (-6.90%)
web/src/repo/RepoRevisionContainer.tsx 58.06% <0.00%> (-6.46%)
web/src/repo/RepoContainer.tsx 73.41% <0.00%> (-1.27%)
.../internal/codeintel/resolvers/graphql/locations.go 85.45% <0.00%> (+1.81%)