Skip to content

remove ci-db-backcompat.sh

Administrator requested to merge sg/rm-db-backcompat into main

Created by: slimsag

Our CI backcompat test is currently useless so I am removing it. It is preventing us from releasing v3.19.1. https://github.com/sourcegraph/sourcegraph/pull/13194

Steps to reproduce the issue:

  1. Add a new DB migration.
  2. Push your branch to CI and observe the following:
+ ./dev/ci/db-backcompat.sh
Running backcompat test between a6443357312dfee151d00a27c85d155be7a41429 (HEAD) and c75df283aac16784ec1b289df943c7e969ad7d65
Latest migration schema version (1528395705) does not match schema in test DB (1528395704).

That's right - it's telling you that the latest migration in the migrations/ folder (1528395705) does not match the DB version found on Sourcegraph.com (1528395704) and therefor your build failed. How are you supposed to address this? I do not know.

I tried to correct it by ignoring that one check with a conditional, but then got basically the same thing:

FAIL: DB schema 1528395704 no longer matches latest schema version 1528395705 after running tests.

The whole point of the test is to ensure that after my migration the old version deployed to sourcegraph.com can properly use the DB during a rolling upgrade - but that clearly isn't working so I am removing it. Someone will need to follow-up if we care about testing this.

Merge request reports