Only restart services with goreman if they're running
Created by: mrnugget
When running ./dev/start.sh
with a modified Procfile
, or passing the
--only
/--except
options to it, the list of running services doesn't
match the list of binaries the watch
command rebuilds.
So what happens is that you modify code, watch
re-compiles the binaries
and runs into an error:
08:54:27 watch | Building with optimizations disabled (for debugging). Make sure you have at least go1.10 installed.
08:54:32 watch | Rebuilt: symbols precise-code-intel-bundle-manager precise-code-intel-worker
08:54:32 watch | goreman: unknown proc: symbols
Because symbols
wasn't running now all three services aren't
restarted.
That cost me a lot of time and caused a ton of facepalms... so here's the fix.
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #12903 into main will increase coverage by
0.32%
. The diff coverage isn/a
.@@ Coverage Diff @@ ## main #12903 +/- ## ========================================== + Coverage 50.85% 51.17% +0.32% ========================================== Files 1454 1454 Lines 81357 81357 Branches 6615 6627 +12 ========================================== + Hits 41371 41632 +261 + Misses 36404 36142 -262 - Partials 3582 3583 +1
Flag Coverage Δ #go 52.63% <ø> (+<0.01%)
#integration 24.27% <ø> (ø)
#storybook 14.12% <ø> (?)
#typescript 47.13% <ø> (+1.19%)
#unit 34.70% <ø> (ø)
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files Coverage Δ cmd/frontend/graphqlbackend/zoekt.go 75.70% <0.00%> (+0.28%)
shared/src/util/url.ts 90.13% <0.00%> (+0.89%)
...c/browser-extension/options-page/ServerUrlForm.tsx 95.55% <0.00%> (+2.22%)
web/src/components/diff/FileDiffHunks.tsx 70.45% <0.00%> (+2.27%)
...d/src/components/activation/ActivationDropdown.tsx 48.57% <0.00%> (+2.85%)
shared/src/util/markdown.ts 80.00% <0.00%> (+3.33%)
...paigns/detail/changesets/ExternalChangesetNode.tsx 52.72% <0.00%> (+3.63%)
...red/src/components/completion/CompletionWidget.tsx 25.00% <0.00%> (+5.00%)
...c/components/completion/EditorCompletionWidget.tsx 5.88% <0.00%> (+5.88%)
web/src/components/FilteredConnection.tsx 79.45% <0.00%> (+8.67%)
... and 22 more
Please register or sign in to reply