Skip to content
Snippets Groups Projects

search: update integration tests for parser migration

Created by: rvantonder

Happy to say that the parser migration passes all of the existing search integration tests. The new parser is stricter about enforcing that type:file is specified with stable:yes (addresses https://github.com/sourcegraph/sourcegraph/issues/9715), so the relevant tests are updated here. There are also some queries that have stable:yes, that we don't technically support yet, so I have updated those tests as well.

The assumption from here on out is that these tests work consistently with the new parser, until I/we put @unknwon's testing work into CI.

There is one discrepancy for a test that returns a slightly different suggested query for a particular alert (ordering is different). This is too low value to try and make consistent, but just noting it.

Old:

Screen Shot 2020-08-06 at 8 12 06 PM

New:

Screen Shot 2020-08-06 at 8 12 46 PM

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading