Skip to content

ci: remove highest firing golanglint-ci

Administrator requested to merge k/silence-golanglint into main

Created by: keegancsmith

This is an attempt to improve the signal of golanglint-ci. It removes the highest firing lints in our codebase. We should probably remove more and stick to just lints that find bugs (like staticcheck). This is a first step.

Ran the following shell command and removed all checks with 50 or more complaints.

golangci-lint run | egrep -o '\([a-z]*\)$' | sort | uniq -c | sort -n
   1 (c)
   1 (ctx)
   1 (govet)
   1 (ineffassign)
   2 (ch)
   2 (compressed)
   2 (contents)
   2 (data)
   2 (errcheck)
   2 (expected)
   2 (file)
   2 (recompressed)
   2 (req)
   2 (staticcheck)
   2 (stored)
   2 (unused)
   3 (bodyclose)
   3 (goimports)
   3 (nakedret)
   3 (rowserrcheck)
   3 (unconvert)
   4 (dogsled)
   4 (nil)
   6 (whitespace)
   7 (deadcode)
   9 (stylecheck)
  12 (interfacer)
  20 (t)
  22 (err)
  29 (gosec)
  49 (misspell)
  50 (dupl)
  50 (gocritic)
  50 (golint)
  50 (unparam)
  56 ()

Merge request reports