Skip to content

search: do not process paths as regexp for structural searcher

Administrator requested to merge rvt/no-regex-file-paths-searcher into master

Created by: rvantonder

Fixes #11831

Before this PR, it was possible that we compile/validate parameters like file:<value> for regexp search in searcher before running comby for a structural search. It could happen that we want to search a file containing metacharacters (in this case a file path like recipes/C++/576559_Fast_prime_generator/recipe-576559.cpp) that is passed directly without any quoting, resulting in the error in the above issue. It's pretty rare to trigger since not many regex metacharacters are valid for file paths, but + is one exception, which is why this wasn't caught till now.

This PR moves the part that is particular to regexp search so that it doesn't affect structural search, and it is safe to treat the file paths literally.

Merge request reports

Loading