Skip to content

Clarify add/update repository actions

Administrator requested to merge lg/add-repo-actions-unclear into master

Created by: lguychard

Rel #10899

Upon adding or updating repositories:

  • Redirect to /site-admin/repositories
  • Display a green success banner at the top of the repository status page (as per figma design) with the text:

Adding repositories. It may take a few moments to clone and index each repository. Repository statuses are displayed below.

The banner will not be removed until the next page is loaded.

image

Implementation notes:

  • Converted relevant components to function components
  • Used a URL query param, repositoriesUpdated, to trigger showing the success banner on /site-admin/repositories
  • Modified FilteredConnection to avoid overwriting existing query parameters, otherwise on initial page load of /site-admin/repositories repositoriesUpdated would get erased.

A couple of questions for @rrhyne:

  • Sometimes, updating an external service will not result in added repositories, but in removed repositories (eg. when narrowing a repository query). The banner wording does not account for this. Should the banner read "Updating repositories..." instead of "Adding repositories..." to account for all cases?
  • Similarly, when deleting an external service, the user remains on /site-admin/external-services, and no banner / confirmation is shown. For consistency, should we also redirect to /site-admin/repositories when deleting an external service?

Merge request reports