Skip to content

repo-updater: Do not block in repoLookup for known repos

Administrator requested to merge k/dotcom-repo-lookup-blocking into master

Created by: keegancsmith

If we have the entry in the DB already, we do not need to block the repoLookup request. For example GitHub has degraded services today, and requests for loading repositories timed out on sourcegraph.com due to this code path. However, if we already have repo metadata we can just return that in repoLookup. We still do what we did before, but in a background goroutine. We still need to do it so we can detect metadata changes (eg renames).

Best reviewed commit by commit.

Merge request reports

Loading