Skip to content

E2e tests: verify that hover contents are visible

Administrator requested to merge lg/e2e-hover-visible into master

Created by: lguychard

https://github.com/sourcegraph/sourcegraph/pull/11545/commits/7d986349a29e6423094a4db0208b8671afb0ec8d removed the { visible: true } check for hover contents, but it's impotant to keep.

That check was broken by making .e2e-tooltip-content display: contents: the element doesn't have a visible bounding rect anymore, so Puppeteer never finds the selector with { visible: true }.

Fixed by looking for any visible child of .e2e-tooltip-content. Also removed the expectedCount logic from getHoverContents(), as it was never used.

Merge request reports