Skip to content

Add argument field to BigQuery event logs

Administrator requested to merge bq-args into master

Created by: dadlerj

@ebrodymoore before this is merged, we need to test that this doesn't break anything with events that actually contain JSON argument data... My #1 concern is that we wouldn't be properly escaping the characters, so an arguments field that looks like {"query_data": { "combined": "<SEARCH STRING>", ... } } would break things if <SEARCH STRING> itself contained {s and ,s and etc.

Would you be able to do that test? Let me know if I can help here!

Note that we are already capturing search query data at https://sourcegraph.com/github.com/sourcegraph/sourcegraph@89f9e5f0889ae3966fe76f65c06ef1f743785386/-/blob/web/src/search/queryTelemetry.tsx#L10:9

Merge request reports