all: Replace common usage of cmp.Diff with testutil.DeepCompare

Review changes
Download
Patches
Plain diff

Closed all: Replace common usage of cmp.Diff with testutil.DeepCompare

testutil-deepcompare into master

Overview 2
Commits 2
Pipelines 0
Changes 39

Closed all: Replace common usage of cmp.Diff with testutil.DeepCompare

Administratorrequested to merge

testutil-deepcompare into master May 26, 2020

Overview 2
Commits 2
Pipelines 0
Changes 39

Created by: ryanslade

It's pretty common in our codebase to use `cmp.Diff':

rg cmp.Diff | wc -l
473

Should we replace it with a helper function?

I've made the change to the simple case where we check for a non empty diff and then call t.Fatal

To cover all cases we'd also need to handle uses of t.Fatalf and t.Error/f

We could add testutil.DeepCompareFatal/f that takes a format string.

WDYT?

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

None

Select assignees

0 Reviewers

None

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

1 Participant

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.