Skip to content

first iteration of simplifying config architecture (RFC 155) (settings service)

Administrator requested to merge twop/kill-config-service into master

Created by: twop

This is for Configuration portion only

WIP on: https://github.com/sourcegraph/sourcegraph/issues/10748 RFC: RFC: https://docs.google.com/document/d/1ikrUNVe3YVbR-JpegxhjrFdmRkTGzTLcOMkKHnOyjuE/edit#

done:

  • removed ExtConfig
  • removed ClientConfig
  • removed settings service instance (although the file remains)
  • created flat APIs interfaces in both directions
  • expanded test suit for configuration in Ext

left:

  • good naming (please give feedback on this one)

  • test suit for configuration on the client side (didn't exist before)

  • better file structure (feedback is appreciated)

Merge request reports