Skip to content
Snippets Groups Projects

Bext: make permissions warning less scary

Merged Administrator requested to merge lg/bext-permissions-warning into master

Created by: lguychard

Context: https://sourcegraph.slack.com/archives/CMT39K56Z/p1589217077358500

A user got concerned when seeing the "grant permissions" notification on a non-GitHub site, thinking that he needed to do it, and uninstalled the browser extension as a result.

This makes the warning more informative, explaining why this is necessary, and on which type of site.

image

Merge request reports

Merged by avatar (Jul 5, 2025 3:31pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: lguychard

    cc @christinaforney @rrhyne

  • Created by: lguychard

    1. We have some docs here, but they don't explain exactly what we do with the permissions, and are in dire need of some love. I would want to improve them before linking to them from the popup.
    2. That's a hard no - that's a Chrome alert, and we cannot control the copy at all.
  • Created by: rrhyne

    The new copy is perfect.

    @christinaforney, under what conditions does the screenshot you posted occur?

    While we cannot control the popup, we could add a link on the extension chrome pointing to the docs other areas of importance:

    sg-exten-docs-links

    Figma link here: https://www.figma.com/file/zUKWluWPKJPEKZHAAqXS3Y/Extension-links?node-id=0%3A1&viewport=1202%2C1034%2C1


  • Created by: christinaforney

    @rrhyne - the screenshot shows up when the user clicks the "grant permissions" link.

    Would the design/copy you suggested only show after the grant permissions info box has been removed (since we are now in a state where the browser extension is correctly configured)?

  • Created by: rrhyne

    @christinaforney I personally would not be concerned about the popup you mentioned as they acted to grant permissions on that domain. If my suggested links were in place they could cancel out and review docs to learn more before granting.

    yes. It wouldn't solve any issues with the initial configuration, but allow them to find out more about the extension. I've revised to show the context on a page where permissions need to be granted.

    exten-copy

  • Created by: christinaforney

    @rrhyne sounds good!

    One last question: the grant permissions looks like a link to more information (vs. a button to take an action). Should we (can we?) change this style?

  • Created by: rrhyne

    @christinaforney here's a mockup of that request:

    Grant-Permissions

  • Created by: lguychard

    @rrhyne @christinaforney implemented your suggestions in bf4e327:

    image

Please register or sign in to reply
Loading