Skip to content

Revert "add extra check to make sure repo name has path"

Administrator requested to merge github/fork/notjrbauer/redirects into master

Created by: notjrbauer

This reverts commit 26a91b91a5819d572d071d1c294de0450ffb3420 and potentially closes https://github.com/sourcegraph/sourcegraph/issues/9274

*deep breath*

The changes added by https://github.com/sourcegraph/sourcegraph/pull/10182 make the code I am reverting no longer necessary. In brief, if an arbitrary error implements NotFound(), Temporary(), or Unauthorized() and bubbles up the stack, a proper response code will be returned from the handler. repoupdater was previously missing these error implementations. As a result, some error cases like not found would cause 500's instead of 404s. That's not the case anymore!

See here for a quick look at where repoupdater is used in this branch

I have a dev env patch on top of the reversion in order to show how I replicated locally (and hitting https://sourcegraph.test:3443/github.com)

Lastly, I couldn't find other tests I could leverage, so I can possibly add some depending on comments.

Merge request reports