Handle in-app links within markdown
Created by: felixfbecker
Prevents full-page reloads when a link is clicked inside markdown, which makes a jarring UX. Code insights need to link to other pages of the app (e.g. directories, files, or search results).
Example (note the full page reload):
The interesting part of this PR is the change in Markdown.tsx. The majority of this PR is adding the history
prop to most components that were missing it, which I did with ts-morph
. I'd be happy to add ts-morph as a tool in a separate PR.
Merge request reports
Activity
Created by: codecov[bot]
Codecov Report
Merging #10198 into master will increase coverage by
0.00%
. The diff coverage is26.58%
.@@ Coverage Diff @@ ## master #10198 +/- ## ======================================= Coverage 43.37% 43.37% ======================================= Files 1386 1386 Lines 76149 76185 +36 Branches 6681 6701 +20 ======================================= + Hits 33029 33048 +19 - Misses 40113 40130 +17 Partials 3007 3007
Flag Coverage Δ #unit 43.37% <26.58%> (+<0.01%)
Impacted Files Coverage Δ shared/src/panel/views/PanelView.tsx 0.00% <ø> (ø)
web/src/Layout.tsx 0.00% <ø> (ø)
web/src/api/APIConsole.tsx 0.00% <0.00%> (ø)
web/src/auth/ResetPasswordPage.tsx 0.00% <0.00%> (ø)
web/src/auth/UsernamePasswordSignInForm.tsx 0.00% <0.00%> (ø)
web/src/components/FilteredConnection.tsx 59.25% <ø> (ø)
web/src/components/SearchResult.tsx 0.00% <ø> (ø)
web/src/components/SearchResultMatch.tsx 0.00% <ø> (ø)
web/src/discussions/DiscussionsComment.tsx 0.00% <0.00%> (ø)
...prise/campaigns/detail/CampaignUpdateSelection.tsx 77.77% <ø> (ø)
... and 100 more Created by: felixfbecker
Here it is: https://gist.github.com/felixfbecker/cfe041c7b1351fcb9e41a25f93fec4ae
Please register or sign in to reply