Skip to content
Snippets Groups Projects

Fix conflicting storybook styles

Merged Administrator requested to merge fix-conflicting-storybook-styles into master

Created by: felixfbecker

Fixes #9701

This is a prerequisite to using them for Percy test.

Each test imports the styles needed for the component to work and renders them in a <style> tag (which gets removed afterwards).

In many cases, shared/ components also import the web styles, because they don't look useable without some styles. We may want to only test the Web wrappers around them, or just use plain Bootstrap. It doesn't solve not relying on those styles in shared/ though, and I don't know a good solution for that yet unfortunately. For now, I just want to fix the storybooks.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: codecov[bot]

    Codecov Report

    Merging #10033 into master will not change coverage. The diff coverage is 0.00%.

    @@           Coverage Diff           @@
    ##           master   #10033   +/-   ##
    =======================================
      Coverage   42.77%   42.77%           
    =======================================
      Files        1348     1348           
      Lines       74019    74019           
      Branches     6648     6648           
    =======================================
      Hits        31663    31663           
      Misses      39495    39495           
      Partials     2861     2861           
    Flag Coverage Δ
    #unit 42.77% <0.00%> (ø)
    Impacted Files Coverage Δ
    ...d/src/components/activation/ActivationDropdown.tsx 0.00% <0.00%> (ø)
Please register or sign in to reply
Loading